Closed
Conversation
arkid15r
reviewed
Jun 8, 2025
tests/api/test_core.py
Outdated
| @patch("builtins.open", new_callable=mock_open, read_data="test_data") | ||
| def test_get_file_valid(self, mock_open): | ||
| Config.path.web_static_dir = os.getcwd() | ||
| filename = os.path.join(Config.path.web_static_dir, "test.txt") |
Collaborator
There was a problem hiding this comment.
I suggest using Path for this kind of operations.
* unittests for database files * ruff fixes
Contributor
Author
|
My bad, ran into some git errors with this. I will make a new PR for this with the requested changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
These are unittest cases for API's core.py file.
Type of change
Checklist
make pre-commit, it didn't generate any changesmake test, all tests passed locally